Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff mode doesn't disable interaction with k8s #886

Closed
KaygorodovIS opened this issue May 14, 2024 · 2 comments
Closed

Diff mode doesn't disable interaction with k8s #886

KaygorodovIS opened this issue May 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@KaygorodovIS
Copy link

KaygorodovIS commented May 14, 2024

Describe the bug
Diff mode flag has no effect on behavior

General info (please complete the following information):

  • OS: linux, docker image diamon/helmwave:0.32.1
  • Helmwave Version 0.32.1

To Reproduce
Steps to reproduce the behavior:

  • Set HELMWAVE_DIFF_MODE to local or none
  • Run helmwave build
  • See the following warnings in the logs
W0514 14:01:04.347045    2191 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
W0514 14:01:04.349341    2191 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
W0514 14:01:04.353740    2191 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
W0514 14:01:04.364872    2191 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
W0514 14:01:04.454007    2191 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.

The warnings themselves are related to k8s settings (update k8s from 1.26 to 1.28) but indicate that k8s is being accessed

@KaygorodovIS KaygorodovIS added the bug Something isn't working label May 14, 2024
@r3nic1e
Copy link
Member

r3nic1e commented May 17, 2024

Diff mode doesn't disable interaction with k8s. It just tunes whether to check diff with another release and how.

I think you are looking for offline_kube_version together with diff-mode=none.

@KaygorodovIS
Copy link
Author

It's work fo me. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants