Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer install does not work #2

Closed
rainman110 opened this issue Jun 23, 2020 · 3 comments
Closed

Developer install does not work #2

rainman110 opened this issue Jun 23, 2020 · 3 comments

Comments

@rainman110
Copy link
Member

Installing via python setup.py install works.

But installing via pip install -e . does not. This is however the preferred way for the development cycle.

lehr-fa added a commit that referenced this issue Oct 28, 2021
@d1saster
Copy link
Member

d1saster commented Sep 3, 2022

Just adding PEP 660 for future reference here. So far I don't know how to make this work together with PEP 517 and 518.

@d1saster
Copy link
Member

d1saster commented Sep 6, 2022

As it turns out PEP660 was implemented by setuptools in pypa/setuptools#3488 (part of the 64.0.0 release, which happened on Aug 11, 2022, so quite fresh) which according to my testing fixes this bug.

Since there are currently only few developers and the editable build is not the standard build, I feel reluctant to add setuptools>=64.0.0 as a build requirement to pyproject.toml. Note that the issue can persist im you (very likely still) have an older version of setuptools in your pip cache. It is best to check with increased verbosity which version of setuptools is used for building mpi4torch, i.e. using pip install -v -e . when installing from a local checkout.

@d1saster d1saster closed this as completed Sep 6, 2022
@d1saster
Copy link
Member

d1saster commented Sep 6, 2022

And pip of course needs also to be younger than 21.3 to have PEP660 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants