Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Docker authentication to CircleCI jobs #8888

Merged
merged 1 commit into from
Oct 15, 2020
Merged

add Docker authentication to CircleCI jobs #8888

merged 1 commit into from
Oct 15, 2020

Conversation

bacongobbler
Copy link
Member

closes #8848

relies on #8884 as it re-uses the same credentials.

add Docker authentication to CircleCI jobs
911e061 
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2020
@bacongobbler bacongobbler added the v2.x Issues and Pull Requests related to the major version v2 label Oct 14, 2020
@bacongobbler bacongobbler added this to the 2.17.0 milestone Oct 14, 2020
mattfarina
mattfarina approved these changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Note, the credentials are already loaded into CircleCI so we do not have to wait on the other PR

@bacongobbler bacongobbler merged commit d9977b8 into helm:dev-v2 Oct 15, 2020
@bacongobbler bacongobbler deleted the fix-8848-dev-v2 branch October 15, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfarina mattfarina mattfarina approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. v2.x Issues and Pull Requests related to the major version v2
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bacongobbler @mattfarina @helm-bot