Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm template --create-namespace does not include namespace manifest #8509

Closed
fredleger opened this issue Jul 23, 2020 · 3 comments
Closed
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@fredleger
Copy link

Output of helm version: 3.2.1

Output of kubectl version: kubectl 1.18.2

Cloud Provider/Platform (AKS, GKE, Minikube etc.): any

I think that most people would wait for the namespace definition to be included in the output if --create-namespace is supported when doing an helm template command.

AMHO the choices are:

  • either clearly refuse --create-namespace with helm template subcommand (which is ok but peaople will then rely to other tooling or issues kubectl commands)
  • or add the manifests creation of the namespace in output (which is better if you rely on helm to generate your manifests)
@bacongobbler
Copy link
Member

This might be related to #8268, where invalid subcommands are being silently accepted as valid input by cobra. This could be extending towards invalid feature flags as well.

I would argue that the first case is preferred here. The namespace should not be part of the output - helm template's only job is to display the output from rendering the templates.

@bacongobbler bacongobbler added the bug Categorizes issue or PR as related to a bug. label Jul 23, 2020
@fredleger
Copy link
Author

hi @bacongobbler

ok it make sense it's related to this cobra bug. thanxs for pointing that out.

i understand the point of helm template being tied to rendering templates. The only reason that would made me prefer the 1st choice is that will enable end users to leverage on helm3 to create manifests in a gitops style approach. There is currently no direct way to do that except some crapy bash tooling. But i guess you are right on the perimeter of helm template and i was more formulating something like helm dump, but i guess this is another enhancement issue.

@bacongobbler
Copy link
Member

Closing in favour of #8268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants