Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetesVersion doesn't work for kubernetes prereleases #6190

Closed
wongma7 opened this issue Aug 8, 2019 · 2 comments
Closed

kubernetesVersion doesn't work for kubernetes prereleases #6190

wongma7 opened this issue Aug 8, 2019 · 2 comments

Comments

@wongma7
Copy link

wongma7 commented Aug 8, 2019

Error: Chart requires kubernetesVersion: >=1.13.0 which is incompatible with Kubernetes v1.15.3-beta.0

v1.15.3-beta.0 is newer than 1.13.0. I expected helm to detect this.

Consider using the version code directly from kubernetes when comparing kubernetes versions https://github.com/kubernetes/apimachinery/blob/master/pkg/util/version/version.go#L290 rather than the semver library https://github.com/helm/helm/blob/master/pkg/version/compatible.go

Similar to #3810 but not specific to GKE.

Output of helm version:
Client: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-07T09:55:27Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.3-beta.0", GitCommit:"7823476aaac5851d51b22020c17777e5684c04c2", GitTreeState:"clean", BuildDate:"2019-08-05T09:36:27Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.): AWS

@wongma7
Copy link
Author

wongma7 commented Aug 8, 2019

Workaround is to use kubeVersion: ">=1.13.0-0"

@bacongobbler
Copy link
Member

Working as intended. Pre-releases are masked by 1.13.0. Adding the prefix modifier allows pre-releases to be evaluated.

pmacik added a commit to pmacik/acceptance-testing that referenced this issue Aug 17, 2020
pmacik added a commit to pmacik/acceptance-testing that referenced this issue Aug 17, 2020
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/acceptance-testing that referenced this issue Aug 17, 2020
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/acceptance-testing that referenced this issue Aug 17, 2020
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to redhat-developer/helm-acceptance-testing that referenced this issue Aug 17, 2020
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to redhat-developer/helm-acceptance-testing that referenced this issue Sep 29, 2020
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pedjak pushed a commit to redhat-developer/helm-acceptance-testing that referenced this issue Dec 16, 2020
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
KiaraGrouwstra added a commit to KiaraGrouwstra/helm-taiga that referenced this issue Jun 11, 2021
pmacik added a commit to redhat-developer/helm-acceptance-testing that referenced this issue Oct 26, 2021
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik pushed a commit to redhat-developer/helm-acceptance-testing that referenced this issue Oct 26, 2021
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
calind added a commit to bitpoke/mysql-operator that referenced this issue Nov 17, 2021
PhanLe1010 added a commit to PhanLe1010/longhorn that referenced this issue Dec 3, 2021
Also, use "-0" instead of "-r0" to capture pre-releases. See
helm/helm#6190

Signed-off-by: Phan Le <phan.le@suse.com>
innobead pushed a commit to longhorn/longhorn that referenced this issue Dec 3, 2021
Also, use "-0" instead of "-r0" to capture pre-releases. See
helm/helm#6190

Signed-off-by: Phan Le <phan.le@suse.com>
pmacik pushed a commit to redhat-developer/helm-acceptance-testing that referenced this issue Apr 5, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to redhat-developer/helm-acceptance-testing that referenced this issue Apr 5, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to redhat-developer/helm-acceptance-testing that referenced this issue Apr 5, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/acceptance-testing that referenced this issue Aug 23, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (helm#2)

-Add openshift cluster provider (helm#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (helm#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (helm#12)

-Adjust completion test according to helm 3.4 flags (helm#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
tisutisu pushed a commit to redhat-developer/helm-acceptance-testing that referenced this issue Sep 22, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
tisutisu pushed a commit to redhat-developer/helm-acceptance-testing that referenced this issue Nov 23, 2022
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Kartikey-star pushed a commit to redhat-developer/helm-acceptance-testing that referenced this issue Feb 28, 2023
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Kartikey-star pushed a commit to redhat-developer/helm-acceptance-testing that referenced this issue Mar 2, 2023
…m commits

-update pip to pip3

-run openshift tests

-Fix test data deployment version

-Install PV before test setup and fix deamon set tests

-Add helm dir in .acceptance

-Change to use current helm bin

-Disable test for version greater than 3.1

-Create blank.yml

-Enable tests related to Helm 3.2 bin. (#2)

-Add openshift cluster provider (#6)
* Run acceptance tests against provided k8s cluster
* Add openshift cluster provider

-Fix kubeVersion to support kube pre-releases (helm/helm#6190) (#9)

-Remove obsolete and redundand test cases from kubernetes_versions.robot (#12)

-Adjust completion test according to helm 3.4 flags (#11)

-Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4.

Modified the openshift-nginx chart to work properly in 4.12

Co-authored-by: Akash Shinde <akashshinde159@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants