Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTest Failed in case TestInstallRelease_Wait_Interrupted #12961

Open
haojingcn opened this issue Apr 18, 2024 · 2 comments
Open

UnitTest Failed in case TestInstallRelease_Wait_Interrupted #12961

haojingcn opened this issue Apr 18, 2024 · 2 comments
Labels
bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@haojingcn
Copy link

Output of helm version: 3.14.4

Output of kubectl version: no

Cloud Provider/Platform (AKS, GKE, Minikube etc.): local

When I'm run project testcase with race flags, it occurs an error.

cmdline: go test -race helm.sh/helm/v3/pkg/action

image

@gjenkins8 gjenkins8 added bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 2, 2024
@gjenkins8
Copy link
Contributor

thanks for the report

@MovieMaker93
Copy link

I would love to contribute on this as a Beginner, could you give me some guidance? I've checked the code e the problem might be in the:

func (i *Install) performInstallCtx(ctx context.Context, rel *release.Release, toBeAdopted kube.ResourceList, resources kube.ResourceList) (*release.Release, error) {
	type Msg struct {
		r *release.Release
		e error
	}
	resultChan := make(chan Msg, 1)

	go func() {
		rel, err := i.performInstall(rel, toBeAdopted, resources)
		resultChan <- Msg{rel, err}
	}()
	select {
	case <-ctx.Done():
		err := ctx.Err()
		return rel, err
	case msg := <-resultChan:
		return msg.r, msg.e
	}
}

In the function

rel, err := i.performInstall(rel, toBeAdopted, resources)

Don't know where exactly is the problem, can you suggest something?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants