[CMD/PKG] Adopted resource not replaced when using upgrade --install --force #11672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Signed-off-by: Vaibhav Sharma <17532va@gmail.com>
VaibhavSharma-47
force-pushed
the
feature
branch
from
d6bfa73
to
3181c7d
Compare
The PR looks good to me. If |
|
@gjenkins8 Any update on this ? |
mattfarina
approved these changes
Jan 10, 2023
|
This makes sense. It enables adopted resources on install to be force restarted. This is required for force to work on upgrade with the install flag. |
sabre1041
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vaibhav Sharma vaibhasharma199904@gmail.com
What this PR does / why we need it:
closes #11585
Adds the support for --force flag to be passed while performing an upgrade.
Special notes for your reviewer:
I saw a comment in the issue discussion regarding putting this behind a feature flag. I am not sure where such flags are maintained in the repo can someone please point that out to me.
If applicable: