Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change linting error messages for null values in arrays #11628

Conversation

dastrobu
Copy link
Contributor

Closes #11627

Signed-off-by: Daniel Strobusch 1847260+dastrobu@users.noreply.github.com

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2022
@joejulian joejulian added this to the 3.10.3 milestone Dec 13, 2022
@hickeyma hickeyma modified the milestones: 3.10.3, 3.11.0 Dec 14, 2022
@dastrobu dastrobu force-pushed the Linting_error_on_null_in_dependencies_is_misleading_#11627 branch from 6d153dc to f3f5caf Compare December 16, 2022 09:34
Copy link
Contributor

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good bar a small nit

pkg/chart/metadata_test.go Outdated Show resolved Hide resolved
Closes helm#11627

Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
@dastrobu dastrobu force-pushed the Linting_error_on_null_in_dependencies_is_misleading_#11627 branch from f3f5caf to 6a5f240 Compare January 5, 2023 17:29
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2023
@dastrobu dastrobu requested a review from hickeyma January 5, 2023 17:53
@hickeyma hickeyma merged commit 1819f1f into helm:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting error on null in dependencies is misleading
3 participants