Add support for CSVs in template --api-versions arg #11490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the template sub-command argument `--api-versions` from `StringArrayVarP` to `StringSliceVarP`, to allow support for comma separated variables. This will allow users to use a syntax such as `--api-versions one,two,three` over `--api-versions one --api-versions two --api-versions three`. Fixes: helm#11485 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
pull-request-size
bot
added
the
size/XS
phil9909
approved these changes
Nov 4, 2022
|
Hey! Just checking in. Is there anything left to do for this before it can be merged? |
|
This is backwards compatible. From the flag handling docs... And, a comma is not an allowed character in a group/version that would impact the input. |
mattfarina
approved these changes
Jan 9, 2023
|
XS PR which can be merged on one maintainer approval. So, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit changes the template sub-command argument
--api-versionsfromStringArrayVarPtoStringSliceVarP, to allow support for comma separated variables. This will allow users to use a syntax such as--api-versions one,two,threeover--api-versions one --api-versions two --api-versions three.Closes #11485
Signed-off-by: Ryan Drew ryan.drew@isovalent.com
Special notes for your reviewer:
Please see #11485 for more details.