Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snakecase template function turns abc_123_def into abc_123__def #11458

Closed
jwhitaker-swiftnav opened this issue Oct 20, 2022 · 6 comments
Closed
Assignees
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@jwhitaker-swiftnav
Copy link

As per the title, running

{{ "abc_123_def" | snakecase }}

in my template givesabc_123__def. I would expect it to give abc_123_def.

I've tracked down the issue to an indirect dependency and raised a PR - huandu/xstrings#52 . However I still want to raise this in helm directly to track until it's fixed and updated.

Thanks!

Output of helm version:

version.BuildInfo{Version:"v3.9.4", GitCommit:"dbc6d8e20fe1d58d50e6ed30f09a04a77e4c68db", GitTreeState:"clean", GoVersion:"go1.17.13"}

Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:57:26Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"23+", GitVersion:"v1.23.10-eks-15b7512", GitCommit:"cd6399691d9b1fed9ec20c9c5e82f5993c3f42cb", GitTreeState:"clean", BuildDate:"2022-08-31T19:17:01Z", GoVersion:"go1.17.13", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
N/A

@hickeyma hickeyma added the bug Categorizes issue or PR as related to a bug. label Oct 21, 2022
@yxxhero
Copy link
Member

yxxhero commented Oct 23, 2022

@hickeyma we need to upgrade https://github.com/Masterminds/sprig if huandu/xstrings#52 has been merged.

@hickeyma
Copy link
Contributor

@yxxhero would you like to push a PR to https://github.com/Masterminds/sprig?

@yxxhero
Copy link
Member

yxxhero commented Oct 24, 2022

@hickeyma yes. if https://github.com/huandu/xstrings is released. I will push a PR for this issue.

@yxxhero
Copy link
Member

yxxhero commented Oct 30, 2022

see: Masterminds/sprig#348

@yxxhero
Copy link
Member

yxxhero commented Oct 30, 2022

@mattfarina ping

@yxxhero yxxhero mentioned this issue Nov 30, 2022
3 tasks
@yxxhero
Copy link
Member

yxxhero commented Dec 5, 2022

see: #11582

@yxxhero yxxhero closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants