Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use intstr.GetScaledValueFromIntOrPercent instead of the deprecated #11439

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

phoenixsqf
Copy link
Contributor

Signed-off-by: phoenixsqf sqfphoenix@163.com

use intstr.GetScaledValueFromIntOrPercent cause intstr.GetValueFromIntOrPercent is deprecated

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2022
@yxxhero
Copy link
Member

yxxhero commented Oct 13, 2022

@phoenixsqf Please fix DCO issue.

@yxxhero
Copy link
Member

yxxhero commented Oct 13, 2022

Signed-off-by: Qifan Shen <sqfphoenix@163.com>
@phoenixsqf
Copy link
Contributor Author

@phoenixsqf Please fix DCO issue.

Fixed.

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero added this to the 3.10.2 milestone Oct 13, 2022
@mattfarina mattfarina modified the milestones: 3.10.2, 3.10.3 Nov 10, 2022
@hickeyma hickeyma modified the milestones: 3.10.3, 3.11.0 Dec 14, 2022
@mattfarina mattfarina merged commit 774c6ce into helm:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants