Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop direct github.com/docker/docker dependency #11233

Merged
merged 1 commit into from Aug 22, 2022

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented Aug 17, 2022

What this PR does / why we need it:

github.com/docker/docker/pkg/term is deprecated and functions in this package are all aliases to github.com/moby/term. This change allows to drop the direct dependency on the repo.

Special notes for your reviewer:

There is at least one more dependency on github.com/docker/docker - oras.land/oras-go/pkg/auth/docker. Looks like v2.0.0 of that package will be released soon. It does not depend on github.com/docker/docker anymore, so perhaps an upgrade would make sense at some point.

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Signed-off-by: Mikhail Mazurskiy <mmazurskiy@gitlab.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2022
Copy link

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero
Copy link
Member

yxxhero commented Aug 21, 2022

LGTM

@yxxhero yxxhero added this to the 3.10.0 milestone Aug 21, 2022
Copy link
Contributor

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ash2k

@hickeyma hickeyma merged commit 72e2bff into helm:main Aug 22, 2022
@ash2k ash2k deleted the drop-docker-docker-dep branch August 22, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants