From 660e4ffe7aae8d33dfe869d01ae75156662365ac Mon Sep 17 00:00:00 2001 From: stan-sz <37585349+stan-sz@users.noreply.github.com> Date: Tue, 5 Apr 2022 12:30:02 +0000 Subject: [PATCH 1/4] Log error message on failed download Signed-off-by: GitHub --- pkg/action/install.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/action/install.go b/pkg/action/install.go index 3872ed5c90f..1e3ceba0c5b 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -766,5 +766,5 @@ func (c *ChartPathOptions) LocateChart(name string, settings *cli.EnvSettings) ( atVersion = fmt.Sprintf(" at version %q", version) } - return filename, errors.Errorf("failed to download %q%s", name, atVersion) + return filename, errors.Errorf("failed to download %q%s because of %s", name, atVersion, err) } From a7e4ae752af018b357f551c653c2b39bc5720313 Mon Sep 17 00:00:00 2001 From: stan-sz <37585349+stan-sz@users.noreply.github.com> Date: Mon, 11 Apr 2022 10:58:48 +0200 Subject: [PATCH 2/4] Update install.go Feedback from PR Signed-off-by: GitHub --- pkg/action/install.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/pkg/action/install.go b/pkg/action/install.go index 1e3ceba0c5b..36dc6b7bb57 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -757,14 +757,7 @@ func (c *ChartPathOptions) LocateChart(name string, settings *cli.EnvSettings) ( return filename, err } return lname, nil - } else if settings.Debug { - return filename, err - } - - atVersion := "" - if version != "" { - atVersion = fmt.Sprintf(" at version %q", version) + } else { + return "", err } - - return filename, errors.Errorf("failed to download %q%s because of %s", name, atVersion, err) } From 6c55d9e3e9f45afd576a9480fcad88d7d9d12ef5 Mon Sep 17 00:00:00 2001 From: stan-sz <37585349+stan-sz@users.noreply.github.com> Date: Mon, 11 Apr 2022 09:14:26 +0000 Subject: [PATCH 3/4] Fix linter Signed-off-by: GitHub --- pkg/action/install.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/action/install.go b/pkg/action/install.go index 36dc6b7bb57..63c20acc08c 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -751,13 +751,13 @@ func (c *ChartPathOptions) LocateChart(name string, settings *cli.EnvSettings) ( } filename, _, err := dl.DownloadTo(name, version, settings.RepositoryCache) - if err == nil { - lname, err := filepath.Abs(filename) - if err != nil { - return filename, err - } - return lname, nil - } else { + if err != nil { return "", err } + + lname, err := filepath.Abs(filename) + if err != nil { + return filename, err + } + return lname, nil } From d8c0e01132705b427d27835f9d3e2e8bb3e4da22 Mon Sep 17 00:00:00 2001 From: stan-sz <37585349+stan-sz@users.noreply.github.com> Date: Mon, 11 Apr 2022 11:11:34 +0000 Subject: [PATCH 4/4] Fix UT Signed-off-by: GitHub --- cmd/helm/show_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/helm/show_test.go b/cmd/helm/show_test.go index 2ecb80a4334..93ec08d0f6b 100644 --- a/cmd/helm/show_test.go +++ b/cmd/helm/show_test.go @@ -47,14 +47,14 @@ func TestShowPreReleaseChart(t *testing.T) { name: "show pre-release chart", args: "test/pre-release-chart", fail: true, - expectedErr: "failed to download \"test/pre-release-chart\"", + expectedErr: "chart \"pre-release-chart\" matching not found in test index. (try 'helm repo update'): no chart version found for pre-release-chart-", }, { name: "show pre-release chart", args: "test/pre-release-chart", fail: true, flags: "--version 1.0.0", - expectedErr: "failed to download \"test/pre-release-chart\" at version \"1.0.0\"", + expectedErr: "chart \"pre-release-chart\" matching 1.0.0 not found in test index. (try 'helm repo update'): no chart version found for pre-release-chart-1.0.0", }, { name: "show pre-release chart with 'devel' flag",