Fix web site scrolling on mobile browsers #1535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrolling pages on the Helm web site is difficult on mobile devices due to nested scrolling containers. This changeset removes the nested scrolling containers. The fix to remove the nested scrolling containers caused pages to start scrolling horizontally because the content of the pages have negative margins, which makes the page wider than 100%. The rest of this changeset addresses the negative margins by removing them and/or offsetting them in each element that was causing the page to horizontal scroll. Fixes helm#741 Fixes helm#1393 Fixes helm#1464 Signed-off-by: Matt Light <matt@tinyprint.dev>
Signed-off-by: Matt Light <matt@tinyprint.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling pages on the Helm web site is difficult on mobile devices due to nested scrolling containers. This changeset removes the nested scrolling containers.
The fix to remove the nested scrolling containers caused pages to start scrolling horizontally because the content of the pages have negative margins, which makes the page wider than 100%. The rest of this changeset addresses the negative margins by removing them and/or offsetting them in each element that was causing the page to horizontal scroll.
Fixes #741
Fixes #1393
Fixes #1464