Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correct/incorrect example in "Templates - Names of Defined Templates" #1457

Open
ILyaCyclone opened this issue Apr 26, 2023 · 0 comments

Comments

@ILyaCyclone
Copy link

On Templates page https://helm.sh/docs/chart_best_practices/templates/#names-of-defined-templates in "Names of Defined Templates" section there is following text:

For that reason, _all defined template names should be namespaced._
Correct:
```yaml
{{- define "nginx.fullname" }}
{{/* ... */}}
{{ end -}}
```
Incorrect:
```yaml
{{- define "fullname" -}}
{{/* ... */}}
{{ end -}}
```

This section describes necessity of using namespaces in variables names, so the key difference is "nginx.fullname" vs "fullname".
But current and incorrect examples are also different in a dash symbol, added at the end of define in incorrect one: "{{- define "fullname" -}}".

I believe the only difference should be in naming: "nginx.fullname" vs "fullname".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant