Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for library charts #237

Open
hairmare opened this issue Jun 23, 2020 · 19 comments
Open

Support for library charts #237

hairmare opened this issue Jun 23, 2020 · 19 comments

Comments

@hairmare
Copy link

Is this a request for help?:

Probably

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

This is a FEATURE REQUEST. I would like to be able to test library charts to
some degree using the chart-testing automation.

This will help with maintaining library charts since it could make it easier to change them if they are properly tested.

Version of Helm and Kubernetes:

"latest"

What happened:

I created a library chart on a repo with the chart-testing GitHub Action enabled.

What you expected to happen:

That chart-testing does some sort or more or less meaningful tests on my library chart.

How to reproduce it (as minimally and precisely as possible):

Run the install tests of chart-testing against a charts/ folder containing a library chart.

Anything else we need to know:

I think there are a few reasonable ideas on how to tackle this but wanted to get some input:

  • this could be out of scope for chart-testing and I should ignore my library. If this is the way to go I should try to always combine any changes to the library chart with changes to an example chart that uses the library (this might result in some sorts of dependency-hell when it comes to managing Chart.lock files in PRs)
  • chart-testing could support a concrete example of the library in the ci/ folder and use that for testing
  • chart-testing could only support linting library charts and not exit with and simply not attempt to install a library chart (i can already do this by ignoring my library chart)
@lukasz-mitka
Copy link

I would go with not event trying to install library charts. Since it's not possible just skip them.

For anyone looking for a workaround: Create separate config file for install only which excludes library charts.

@gionn
Copy link

gionn commented Feb 2, 2023

We have a library chart among other charts, it's quite surprising to see that libraries chart are not supported.

Before discovering this issue, I had also to create an empty values.yaml otherwise was even failing earlier.

Will try to use a separated config for ct install but looks really clunky.

Wielewout added a commit to accelleran/helm-charts that referenced this issue Jun 12, 2023
See helm/chart-testing#237.
Add an empty values file in the CI to library charts for the linter.
Exclude library charts for the installer.
Wielewout added a commit to accelleran/helm-charts that referenced this issue Jun 27, 2023
See helm/chart-testing#237.
Add an empty values file in the CI to library charts for the linter.
Exclude library charts for the installer.
Wielewout added a commit to accelleran/helm-charts that referenced this issue Jun 27, 2023
See helm/chart-testing#237.
Add an empty values file in the CI to library charts for the linter.
Exclude library charts for the installer.
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 29, 2023
@lukasz-mitka
Copy link

bad bot.
Still needed.

@github-actions github-actions bot removed the Stale label Nov 30, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 31, 2023
@hairmare
Copy link
Author

most likely ct should just skip library charts during ct install, but it should lint them during ct lint. I can do this now using two different configs, but keeping those up to date feels error prone and a lot of manual work.

would a change that just makes ct install skip library charts be a welcome change?

@davidkarlsen
Copy link
Member

@hairmare I'd say that makes sense. Just skip them and print a warning.

@github-actions github-actions bot removed the Stale label Jan 1, 2024
@cpanato
Copy link
Member

cpanato commented Jan 19, 2024

+1 with tests :)

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 19, 2024
@lukasz-mitka
Copy link

bad bot.
Still needed.

@cpanato
Copy link
Member

cpanato commented Feb 19, 2024

bad bot.

Still needed.

Are willing to work on this and open a pr?

@github-actions github-actions bot removed the Stale label Feb 20, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 21, 2024
@lukasz-mitka
Copy link

Are willing to work on this and open a pr?

No, sorry, no time to spare.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 23, 2024
@lukasz-mitka
Copy link

bad bot

@cpanato cpanato removed the Stale label Apr 23, 2024
@lukasz-mitka
Copy link

@cpanato Could you set an exempt-issue-labels for these kind of issues?

@cpanato
Copy link
Member

cpanato commented Apr 23, 2024

sounds good @lukasz-mitka

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 24, 2024
@lukasz-mitka
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

bad bot!

@cpanato cpanato added frozen and removed Stale labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants