fix: Typo in README #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehorsnell
force-pushed
the
fix_typo_in_readme
branch
from
dabde26
to
b3f38e5
Compare
PR helm#75 had a small typo in the args to `ct` - it should be `--target-branch`. Also, rather than hard-coding `main`, we can use the event [context][1] to get the name of the default branch if it's something different (eg `master`). [1]: https://docs.github.com/en/actions/learn-github-actions/contexts Signed-off-by: Joe Horsnell <github@joehorsnell.com>
joehorsnell
force-pushed
the
fix_typo_in_readme
branch
from
b3f38e5
to
fec8f4f
Compare
shink
added a commit
to shink/inlong
that referenced
this pull request
Mar 30, 2022
reference: helm/chart-testing-action#81 issue: apache#3473
|
Hey @unguiculus @scottrigby @davidkarlsen I just ran into this typo from the example, could someone review this, please? Thanks! It looks like a couple of other folks have had the same experience. 😉 #83 #84 Thanks for putting up the fix @joehorsnell ! |
davidkarlsen
approved these changes
Apr 6, 2022
kodiakhq bot
pushed a commit
to cloudquery/helm-charts
that referenced
this pull request
Aug 11, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [helm/chart-testing-action](https://togithub.com/helm/chart-testing-action) | action | minor | `v2.2.1` -> `v2.3.0` | --- ### Release Notes <details> <summary>helm/chart-testing-action</summary> ### [`v2.3.0`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.3.0) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.2.1...v2.3.0) #### What's Changed - fix: Typo in README by [@​joehorsnell](https://togithub.com/joehorsnell) in [helm/chart-testing-action#81 - Specify target branch of ct lint in example workflow by [@​jenting](https://togithub.com/jenting) in [helm/chart-testing-action#88 - chore: update yamllint version by [@​DerekTBrown](https://togithub.com/DerekTBrown) in [helm/chart-testing-action#91 - update action to default chart-testing install to v3.7.0 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#94 - feat: add version override flags by [@​DerekTBrown](https://togithub.com/DerekTBrown) in [helm/chart-testing-action#92 #### New Contributors - [@​joehorsnell](https://togithub.com/joehorsnell) made their first contribution in [helm/chart-testing-action#81 - [@​jenting](https://togithub.com/jenting) made their first contribution in [helm/chart-testing-action#88 - [@​DerekTBrown](https://togithub.com/DerekTBrown) made their first contribution in [helm/chart-testing-action#91 **Full Changelog**: helm/chart-testing-action@v2.2.1...v2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTQuNyIsInVwZGF0ZWRJblZlciI6IjMyLjE1NC43In0=-->
juanjjaramillo
pushed a commit
to newrelic/helm-charts
that referenced
this pull request
Jan 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [helm/chart-testing-action](https://togithub.com/helm/chart-testing-action) | action | minor | `v2.1.0` -> `v2.6.1` | --- ### Release Notes <details> <summary>helm/chart-testing-action (helm/chart-testing-action)</summary> ### [`v2.6.1`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.6.1) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.6.0...v2.6.1) ##### What's Changed - bump ct to v3.10.1 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#136 **Full Changelog**: helm/chart-testing-action@v2...v2.6.1 ### [`v2.6.0`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.6.0) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.5.0...v2.6.0) #### What's Changed - docs: bump helm/kind-action version by [@​dunglas](https://togithub.com/dunglas) in [helm/chart-testing-action#122 - bump ct to v3.10.0 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#134 **Full Changelog**: helm/chart-testing-action@v2...v2.6.0 ### [`v2.5.0`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.5.0) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.4.0...v2.5.0) #### What's Changed - Download binary with right arch by [@​Ludea](https://togithub.com/Ludea) in [helm/chart-testing-action#118 - Bump ct and cleanup script by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#124 - Bump sigstore/cosign-installer from [`c3667d9`](https://togithub.com/helm/chart-testing-action/commit/c3667d99424e7e6047999fb6246c0da843953c65) to [`6e04d22`](https://togithub.com/helm/chart-testing-action/commit/6e04d228eb30da1757ee4e1dd75a0ec73a653e06) by [@​dependabot](https://togithub.com/dependabot) in [helm/chart-testing-action#125 - Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [helm/chart-testing-action#127 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [helm/chart-testing-action#128 #### New Contributors - [@​Ludea](https://togithub.com/Ludea) made their first contribution in [helm/chart-testing-action#118 - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [helm/chart-testing-action#125 **Full Changelog**: helm/chart-testing-action@v2.4.0...v2.5.0 ### [`v2.4.0`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.4.0) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.3.1...v2.4.0) ##### What's Changed - Retry artifact downloads by [@​steven-sheehy](https://togithub.com/steven-sheehy) in [helm/chart-testing-action#111 - fix example workflow by [@​CrowdSalat](https://togithub.com/CrowdSalat) in [helm/chart-testing-action#115 - docs: only run chart lint if changed by [@​fty4](https://togithub.com/fty4) in [helm/chart-testing-action#106 - docs: use GITHUB_OUTPUT in example workflow by [@​fty4](https://togithub.com/fty4) in [helm/chart-testing-action#107 - Use cosign to verify the release and update chart-testing to v3.8.0 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#116 ##### New Contributors - [@​steven-sheehy](https://togithub.com/steven-sheehy) made their first contribution in [helm/chart-testing-action#111 - [@​CrowdSalat](https://togithub.com/CrowdSalat) made their first contribution in [helm/chart-testing-action#115 - [@​fty4](https://togithub.com/fty4) made their first contribution in [helm/chart-testing-action#106 **Full Changelog**: helm/chart-testing-action@v2...v2.4.0 ### [`v2.3.1`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.3.1) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.3.0...v2.3.1) #### What's Changed - bump ct to v3.7.1 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#96 **Full Changelog**: helm/chart-testing-action@v2.3.0...v2.3.1 ### [`v2.3.0`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.3.0) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.2.1...v2.3.0) #### What's Changed - fix: Typo in README by [@​joehorsnell](https://togithub.com/joehorsnell) in [helm/chart-testing-action#81 - Specify target branch of ct lint in example workflow by [@​jenting](https://togithub.com/jenting) in [helm/chart-testing-action#88 - chore: update yamllint version by [@​DerekTBrown](https://togithub.com/DerekTBrown) in [helm/chart-testing-action#91 - update action to default chart-testing install to v3.7.0 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#94 - feat: add version override flags by [@​DerekTBrown](https://togithub.com/DerekTBrown) in [helm/chart-testing-action#92 #### New Contributors - [@​joehorsnell](https://togithub.com/joehorsnell) made their first contribution in [helm/chart-testing-action#81 - [@​jenting](https://togithub.com/jenting) made their first contribution in [helm/chart-testing-action#88 - [@​DerekTBrown](https://togithub.com/DerekTBrown) made their first contribution in [helm/chart-testing-action#91 **Full Changelog**: helm/chart-testing-action@v2.2.1...v2.3.0 ### [`v2.2.1`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.2.1) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.2.0...v2.2.1) #### What's Changed - fix: target main branch by default in the example by [@​lemeurherve](https://togithub.com/lemeurherve) in [helm/chart-testing-action#75 - update ct to use release v3.5.1 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#80 #### New Contributors - [@​lemeurherve](https://togithub.com/lemeurherve) made their first contribution in [helm/chart-testing-action#75 **Full Changelog**: helm/chart-testing-action@v2.2.0...v2.2.1 ### [`v2.2.0`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.2.0) [Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.1.0...v2.2.0) ##### What's Changed - docs: bump version of the action in README.md by [@​dunglas](https://togithub.com/dunglas) in [helm/chart-testing-action#71 - docs: update kind-action version in README by [@​hairmare](https://togithub.com/hairmare) in [helm/chart-testing-action#72 - Update ct to 3.50 by [@​cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#78 ##### New Contributors - [@​dunglas](https://togithub.com/dunglas) made their first contribution in [helm/chart-testing-action#71 - [@​hairmare](https://togithub.com/hairmare) made their first contribution in [helm/chart-testing-action#72 - [@​cpanato](https://togithub.com/cpanato) made their first contribution in [helm/chart-testing-action#78 **Full Changelog**: helm/chart-testing-action@v2.1.0...v2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/newrelic/helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #75 had a small typo in the args to
ct- it should be--target-branch.Also, rather than hard-coding
main, we can use the event context to get the name of thedefault branch if it's something different (eg
master).