Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kubectl with Kubernetes Python client #3

Open
jdolitsky opened this issue Jul 23, 2019 · 4 comments
Open

Replace kubectl with Kubernetes Python client #3

jdolitsky opened this issue Jul 23, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@jdolitsky
Copy link
Collaborator

Instead of shelling out to kubectl, should just import and use the Python library: https://github.com/kubernetes-client/python

@jdolitsky jdolitsky added the help wanted Extra attention is needed label Jul 23, 2019
skylarcalvert added a commit to skylarcalvert/acceptance-testing that referenced this issue Aug 20, 2019
Seeking feedback on the approach to resolve issue helm#3
@akashshinde
Copy link
Contributor

/assign

@marckhouzam
Copy link
Member

I wonder if such a change would actually cause the code to be harder to maintain?
With the use of our Sh.py package, it is often straightforward to use kubectl. Such as:

Should pass  kubectl get nodes
Sh.Run  kubectl get pods --namespace=default

@jdolitsky do you still see this issue as a valuable improvement?

@jdolitsky
Copy link
Collaborator Author

@marckhouzam I think for commands which require counting number of results etc. this would simply alot

For example this function: https://github.com/helm/acceptance-testing/blob/master/lib/Kubectl.py#L17

@marckhouzam
Copy link
Member

Agreed

pmacik referenced this issue in redhat-developer/helm-acceptance-testing May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants