Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-double or similar #75

Open
runspired opened this issue Feb 26, 2017 · 5 comments
Open

Add test-double or similar #75

runspired opened this issue Feb 26, 2017 · 5 comments
Labels

Comments

@runspired
Copy link
Collaborator

We end up needing to double/stub lots of APIs in our tests in order to support browser, node, phantom and IE9. Instead of the ad-hoc way we've been doing this, we should add test-double, sinon or similar.

@hjdivad
Copy link
Collaborator

hjdivad commented Mar 1, 2017

Seems okay. I'd prefer sinon over test-double unless there's some particular reason for the latter.

@stefanpenner
Copy link
Member

My personal preference is test-double 🥇

@hjdivad
Copy link
Collaborator

hjdivad commented Apr 4, 2017

We can totally use test double for this.

Me and @rwjblue can just mutter to ourselves when working on the tests 😉 .

@rwjblue
Copy link
Contributor

rwjblue commented Apr 4, 2017

TBH, I probably would be muttering from the typescript anyways....

@runspired
Copy link
Collaborator Author

mutters...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants