node.remove check entire stack

[hjdivad]

we noted this when implementing it, but it has actually caused problems in ember-cli now

[runspired]

@hjdivad could you elaborate?

[stefanpenner]

@runspired I believe the issue is, mid-built failures (or some async behavior) can legitimately cause orphaned nodes, that should still be removable?

[hjdivad]

let p = heimdall.start('p');
let c = heimdall.start('c');

heimdall.stack === ['p', 'c']

// this will throw because `c` is the current node
c.remove()

// this will not throw, even though `p` is on the stack, it's not at the top of the stack
p.remove()

I think we didn't walk the stack out of some sense of the cost, but remove is a pretty rare operation and the overhead probably doesn't matter that much (especially in comparison to eg start)