Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle error cases more gracefully in v3 #70

Open
hjdivad opened this issue Feb 15, 2017 · 4 comments
Open

handle error cases more gracefully in v3 #70

hjdivad opened this issue Feb 15, 2017 · 4 comments

Comments

@hjdivad
Copy link
Collaborator

hjdivad commented Feb 15, 2017

When something downstream adds nodes and then errors the stack can get imbalanced.

This is less of a problem in v0.3, but there's still a couple of things we likely want to do

  1. indicate that things are unbalanced in the output
  2. autoclose for .stack &c.
@hjdivad
Copy link
Collaborator Author

hjdivad commented Feb 15, 2017

For both v0.2 and v0.3, I'm tempted to make stop unwind the stack (ie keep stopping until the token's node is stopped). This makes it easier to do things like instrument builds in ember-cli and detach a build subtree after reporting it, even if downstream has created something unbalanced.

@stefanpenner @runspired @rwjblue what do you think?

@hjdivad
Copy link
Collaborator Author

hjdivad commented Feb 15, 2017

we should mark autoclosed nodes so analysis can highlight that the subgraph stats totals are correct, but within the individual subgraph the stats might be misallocated

@runspired
Copy link
Collaborator

this should already happen in v3, or perhaps the work I did with @chadhietala didn't get pushed up?

@hjdivad
Copy link
Collaborator Author

hjdivad commented Feb 16, 2017

@runspired cool we just need to work it in to the rest of the ecosystem (eg heimdalljs-graph)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants