Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let schemas specify their own toJSON #13

Open
hjdivad opened this issue Aug 12, 2016 · 3 comments
Open

let schemas specify their own toJSON #13

hjdivad opened this issue Aug 12, 2016 · 3 comments

Comments

@hjdivad
Copy link
Collaborator

hjdivad commented Aug 12, 2016

consider case of saving an existing frame and only pull from it at serialization time

@hjdivad
Copy link
Collaborator Author

hjdivad commented Aug 12, 2016

quite possibly allow toJSON to return virtual nodes (eg as an array [0, 100], [20, 80], [40, 60])

@hjdivad
Copy link
Collaborator Author

hjdivad commented Aug 16, 2016

think about how to fit this in sensibly with #16

@hjdivad hjdivad mentioned this issue Aug 31, 2016
2 tasks
@wycats
Copy link

wycats commented Sep 1, 2016

I wanted to leave some notes explaining what requirements I had in mind. I would like to be able to:

  • put a lot of high-fidelity markers in Glimmer that I leave in unconditionally.
  • control the code that runs when the markers are reached, so that it's possible to make them do nothing at all.
  • allow these markers to represent starting and ending events, and be able to track the time between them, but while still maintaining the ability to turn these markers into noops.
  • to track nesting (before:render -> before:render -> after:render -> after:render has two conceptual "frames") without being forced to reify Heimdall context nodes; in the case of Glimmer, I already have perfectly suitable frames lying around that I can add the context information to.
  • for this aggregate information to be usable to general-purpose aggregation tools that want to present things like "ordered self time" or a tree visualization.

I am willing to accept a requirement that time must be tracked using Heimdall's preferred clock (performance.now in Chrome) if it is to be included in aggregation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants