This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Ensure fs.Stats
(and other classes on fs
) are not mutated.
#23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.Stats
is a standard prototypal class (e.g.function Stats() {}
), so it was being wrapped by ourfs
monitoring system. Unfortunately, wrappingfs.Stats
in a plain function (which didreturn original.apply(this, arguments)
) doesn't properly emulate a number of "standard" class behaviors. Specifically:fs.Stats.prototype
does not refer to the original prototypeThis last item was causing the following error when using
esm
:This is because
esm
is essentially doing:To stash off the
isFile
implementation for recurring usage. The fact that when wrappedfs.Stat.prototype.isFile
was undefined caused the error.