Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all heimdall code is stripped (nitpick) #1

Open
stefanpenner opened this issue Feb 24, 2017 · 3 comments
Open

not all heimdall code is stripped (nitpick) #1

stefanpenner opened this issue Feb 24, 2017 · 3 comments

Comments

@stefanpenner
Copy link
Member

loader.js still has the following heimdall related code post stripping:

var heimdall = global.heimdall;
@runspired
Copy link
Contributor

@stefanpenner I'll add something for this, but the loader.js error on registerMonitor sounds like something else?

@stefanpenner
Copy link
Member Author

yes the error is not related.

@stefanpenner
Copy link
Member Author

This is merely 1 tiny bit of dead code. Something uglify may actually strip out (if so that may be enough, but needs testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants