Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store user-provided access tokens in CredentialsContainer #5545

Open
ErikMichelson opened this issue Apr 3, 2024 · 0 comments
Open

Store user-provided access tokens in CredentialsContainer #5545

ErikMichelson opened this issue Apr 3, 2024 · 0 comments
Labels
type: feature enhancement An improvement to existing functionality
Milestone

Comments

@ErikMichelson
Copy link
Member

Which part of the project should be enhanced?

frontend -> exports to external services

Is your enhancement request related to a problem? Please describe.

When using external services for export like GitHub Gist or GitLab snippets, a user has to re-enter their access token for that service each time. This requires them to store the token in a secure but accessible place like a password-manager and might not seem intuitive.

Describe the solution you'd like

When initially entering a token and confirming the export, the user should be asked whether the access token may be remembered by the browser securely.
If the user accepts this, a new Credential using the API for the CredentialsContainer will be created. Upon further exports the client checks for the presence of such a stored credential.

Note, that it should be made transparent to the user that the access token will be only stored in their browser but never be transferred to the HedgeDoc server. And in addition that therefore HedgeDoc instance administrators won't have the ability to compromise the user's account.

Describe alternatives you've considered

As storing the tokens in a less-secure way (like localStorage) is no option and it should also not be transferred to the server, there aren't any real alternatives.

Additional context

No response

@ErikMichelson ErikMichelson added the type: feature enhancement An improvement to existing functionality label Apr 3, 2024
@ErikMichelson ErikMichelson added this to the Version 2.x milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature enhancement An improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant