Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apache back-end reverse-proxying directives #5447

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

KaKi87
Copy link

@KaKi87 KaKi87 commented Jan 30, 2024

Component/Part

Documentation

Description

This PR fixes the Apache reverse-proxying directives (ProxyPass) of the back-end missing a path parameter, e.g. causing the front-end to hit //private/config when actually requesting /api/private/config.

Steps

  • Added implementation
  • Added / updated tests
  • Added / updated documentation
  • Added changelog snippet
  • I read the contribution documentation and
    made sure that:
    • My commits are signed-off to accept the DCO.
    • This PR targets the correct branch: master for 1.x & docs, develop for 2.x

Related Issue(s)

Closes #5431

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17aade0) 57.66% compared to head (8647700) 57.66%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5447   +/-   ##
========================================
  Coverage    57.66%   57.66%           
========================================
  Files          418      418           
  Lines        12058    12058           
  Branches      1007     1007           
========================================
  Hits          6953     6953           
  Misses        5048     5048           
  Partials        57       57           
Flag Coverage Δ
backend 87.62% <ø> (ø)
backend-e2e-tests 74.34% <ø> (ø)
backend-unit-tests 85.73% <ø> (ø)
e2e-tests 74.34% <ø> (ø)
frontend 39.51% <ø> (ø)
frontend-unit-tests 39.51% <ø> (ø)
unit-tests 51.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HedgeDoc v2 : backendErrorMessage: 'Cannot GET //private/config'
1 participant