Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace [data-turbo-cache=false] with [data-turbo-temporary] #5662

Open
eduardoyutaka opened this issue Dec 12, 2023 · 0 comments
Open

Replace [data-turbo-cache=false] with [data-turbo-temporary] #5662

eduardoyutaka opened this issue Dec 12, 2023 · 0 comments

Comments

@eduardoyutaka
Copy link

Environment

  • Ruby 3.2.2
  • Rails 7.1.2
  • Devise 4.9.3

Current behavior

The default _error_messages.html.erb partial uses a deprecated Turbo attribute data-turbo-cache=false

This attribute was deprecated on Feb 15 2023 in this pull request

Expected behavior

Use more up-to-date attribute name called data-turbo-temporary to avoid deprecation issues and reduce developer confusion as data-turbo-temporary is the only attributed mentioned in Turbo Drive's documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant