Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirmation_sent_at is set regardless skip_confirmation_notification! method call #5659

Open
bogdanvlviv opened this issue Dec 8, 2023 · 1 comment
Open

confirmation_sent_at is set regardless skip_confirmation_notification! method call #5659

bogdanvlviv opened this issue Dec 8, 2023 · 1 comment

Comments

@bogdanvlviv
Copy link
Contributor

Related to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138501#note_1686234692

User's confirmation_sent_at is set regardless skip_confirmation_notification! when creating new user.
@bogdanvlviv
Copy link
Contributor Author

bogdanvlviv commented Dec 8, 2023 •
edited

I found the reason why confirmation_sent_at is always set #4536 (comment). I think we should add a new column to track when confirmation token was generated instead of using confirmation_sent_at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bogdanvlviv