Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPRECATION WARNING: Rails.application.secrets is deprecated in favor of Rails.application.credentials and will be removed in Rails 7.2. #5648

Closed
issei-m opened this issue Oct 25, 2023 · 2 comments
Closed

DEPRECATION WARNING: Rails.application.secrets is deprecated in favor of Rails.application.credentials and will be removed in Rails 7.2. #5648

issei-m opened this issue Oct 25, 2023 · 2 comments

Comments

@issei-m
Copy link

issei-m commented Oct 25, 2023 •
edited

Triggered at

devise/lib/devise/secret_key_finder.rb

Line 12 in e2242a9

elsif @application.respond_to?(:secrets) && key_exists?(@application.secrets)

In our application, we don't use credentials since all credentials, including the secret key base, are sourced from environment variables. In such cases, this deprecation notice gets triggered.
@pil0u
Copy link

pil0u commented Oct 27, 2023

Likely a dupe for #5644

@issei-m
Copy link
Author

issei-m commented Oct 27, 2023

@pil0u Indeed. Thank you for pointing that out!

@issei-m issei-m closed this as completed Oct 27, 2023
JuanVqz added a commit to JuanVqz/doctors that referenced this issue Mar 5, 2024
@JuanVqz
Fix Devise deprecation warning
dd2d307 
Even I'm using Rails credentials I got this deprecation warning from Devise,
Rails secrets will be removed on Rails 7.2, and Devise still having it
and generating a secure key.

heartcombo/devise#5645
heartcombo/devise#5648
@JuanVqz JuanVqz mentioned this issue Mar 5, 2024
Merged
JuanVqz added a commit to JuanVqz/doctors that referenced this issue Mar 5, 2024
@JuanVqz
Fix Devise deprecation warning
41e7537 
Even I'm using Rails credentials I got this deprecation warning from Devise,
Rails secrets will be removed on Rails 7.2, and Devise still having it
and generating a secure key.

heartcombo/devise#5645
heartcombo/devise#5648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@issei-m @pil0u