Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven PIT plugin does not support Maven's late property evaluation in argLine #1131

Closed
uhafner opened this issue Dec 15, 2022 · 3 comments · Fixed by #1136
Closed

Maven PIT plugin does not support Maven's late property evaluation in argLine #1131

uhafner opened this issue Dec 15, 2022 · 3 comments · Fixed by #1136

Comments

@uhafner
Copy link

uhafner commented Dec 15, 2022

In Jenkins plugins we are using Maven's late property evaluation to update the argLine in our builds. This new Maven feature seems to be not yet supported by PIT's maven plugin: it does not resolve those variables and breaks the build, because the extracted argLine is illegal now.

Created argLine from PIT (pitest-maven:1.9.11:mutationCoverage):

argLine=-Xms768M -Xmx768M -XX:+HeapDumpOnOutOfMemoryError -XX:+TieredCompilation -XX:TieredStopAtLevel=1 @{jenkins.addOpens} @{jenkins.insaneHook}

Error message of PIT:

10:05:12 PM PIT >> INFO : MINION : Error: could not open `{jenkins.addOpens}'

You can see the full log of the build at https://github.com/jenkinsci/plugin-util-api-plugin/actions/runs/3708263309/jobs/6285636460

@hcoles
Copy link
Owner

hcoles commented Jan 4, 2023

@uhafner Thanks, wasn't aware of late property evaluation. Will take a look at what's involved.

@uhafner
Copy link
Author

uhafner commented Jan 5, 2023

Thanks for fixing this so fast!

🎉 🎉 🎉

@hcoles
Copy link
Owner

hcoles commented Jan 5, 2023

@uhafner I skimped a little on the integration testing for this one. Let me know if you hit any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants