Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregator resolves wrong files when they have the same filename (Kotlin) #1105

Closed
Pfoerd opened this issue Nov 8, 2022 · 2 comments
Closed

Comments

@Pfoerd
Copy link
Contributor

Pfoerd commented Nov 8, 2022

Describe the bug
The Aggregator doesn’t resolve filenames correctly when there are Kotlin files with the same filename in multiple subprojects. In the pitest reports of the submodules everything is correct and the filenames are resolved correctly but in the aggregated report the files are not assigned correctly. It displays the wrong file from another submodule.

To Reproduce
Steps to reproduce the behavior:

  1. Multi-Module Kotlin Setup
  2. Run Pitest for all Submodules
  3. Run ReportAggregator

Expected behavior
All files are resolved correctly in the aggregated report

used version:
1.9.8

@hcoles
Copy link
Owner

hcoles commented Nov 14, 2022

I've merged a change that will ensure the correct file is used when two modules have files with the same name that define classes in different packages, but the files are not within directories matching those packages.

If the same package is used in both modules, it is not clear what a "correct" behaviour would be so this scenario is not supported.

@Pfoerd Pfoerd closed this as completed Nov 14, 2022
@Pfoerd
Copy link
Contributor Author

Pfoerd commented Nov 14, 2022

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants