Capture all classloaders loading mutant for roboelectric and quarkus #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcoles
force-pushed
the
feature/roboelectric
branch
from
75056c8
to
2909dcc
Compare
added 4 commits
November 16, 2022 10:24
Quarkus, Roboelectric (and possibly other frameworks) load the class under test in a classloader that is not set as the context loader when pitest starts. A previous change got things working with Quarkus, but Roboelectric complicates things further by persisting the classloaders between tests. We must therefore keep track of all classloaders used to load a mutated class, and insert each mutant into all of them. This would have been complicated in earlier version of pitest by the possibility that the same JVM might be used to mutate multiple classes. This would requite the bytes of each class to be stored so that unmutated class could be restored. At some point, a change seems to have been made such that only 1 class is ever mutated per jvm. Experiments to reintroduce multiple class mutations (inners, lambdas etc) did not result in a performance increase in sample code bases. 1 class per jvm is therefore now made a guarantee to allow the code to be much simpler.
We now have an explicit assumption of 1 mutated class per jvm. Allowing arbritrary mutant groupings may violate this.
hcoles
force-pushed
the
feature/roboelectric
branch
from
97589de
to
f9b727a
Compare
hcoles
force-pushed
the
feature/roboelectric
branch
from
9d7fefc
to
e1ad19f
Compare
hcoles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.