Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Maven Site Plugin 3.12.0+ #1038

Merged
merged 2 commits into from Jun 22, 2022
Merged

Conversation

l0s
Copy link
Contributor

@l0s l0s commented Jun 18, 2022

This breaks backward compatibility with maven-site-plugin:3.4.x and possibly other old versions as well. A revision bump is recommended.

This commit updates the Maven plugin-related dependencies and modifies any code affected by breaking changes. Note, some artifact versions were specified using a common property. However, it appears those artifacts no longer follow the same versioning scheme.

Closes #1037

This breaks backward compatibility with `maven-site-plugin:3.4.x` and
possibly other old versions as well. A revision bump is recommended.

This commit updates the Maven plugin-related dependencies and modifies any
code affected by breaking changes.

Closes hcoles#1037
@hcoles
Copy link
Owner

hcoles commented Jun 20, 2022

Thanks for the report and the fix.

4.0 of the maven site plugin looks to be a milestone rather than an official release. Given that this will break compatibility with earlier releases I'm relunctant to merge this until there is an official release of the 4.0 branch.

An alternative would be to pull the reporting plugin out of the main codebase and release it independently as a project under https://github.com/pitest.

@l0s
Copy link
Contributor Author

l0s commented Jun 21, 2022

@hcoles thanks for taking a look. However, I verified that the issue also occurs with version 3.12.0. I updated the example project to reflect that. I also verified that this PR works with 3.12.0.

Moving the reporting plugin out of the main codebase would also make sense. It would avoid the need to override version properties from the parent POM. If you would like me to go that route, let me know.

@l0s l0s changed the title Support Maven Site Plugin 4.0.x Support Maven Site Plugin 3.12.0+ Jun 21, 2022
@hcoles
Copy link
Owner

hcoles commented Jun 21, 2022

@l0s Does everything work for projects using 4.0 if pitest depends 3.12.0? If so, that seems like the easiest route forward.

This downgrades the `maven-reporting-*` libraries to use the latest
non-milestone version. In addition, the integration tests are updated to use
the latest non-milestone version of `maven-site-plugin`.

Note that the surefire dependencies need to remain on a milestone version to
avoid missing class errors.

Closes hcoles#1037
@l0s
Copy link
Contributor Author

l0s commented Jun 22, 2022

@hcoles I pushed a commit that downgrades the maven-reporting-* dependencies to 3.1.0 instead of the 4.0 milestone. Unfortunately, I had to keep the Surefire dependencies on the latest milestone. Without those, I was seeing numerous ClassNotFoundException instances when running the unit tests. Let me know what you think of this approach and if you'd like me to continue investigating the issue with the Surefire dependencies.

@hcoles
Copy link
Owner

hcoles commented Jun 22, 2022

Thanks @l0s, I'll get this merged in for the 1.9.0 release.

@hcoles hcoles merged commit 2f11641 into hcoles:master Jun 22, 2022
@l0s
Copy link
Contributor Author

l0s commented Jun 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven Site Report Silently Fails
2 participants