Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12.z] Remember previously joined member addresses in TcpIpJoiner #21860

Merged

Conversation

ufukyilmaz
Copy link
Contributor

This PR is the partial backport of #21552.
It only includes address remembering mechanism, not include the config update part.

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@ufukyilmaz ufukyilmaz added this to the 3.12.13 milestone Jul 27, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Jul 27, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Jul 27, 2022
@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.20:check (source-java6-check) on project hazelcast: Signature errors found. Verify them and ignore them with the proper annotation if needed. -> [Help 1]
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_2/hazelcast/src/main/java/com/hazelcast/cluster/impl/TcpIpJoiner.java:485: Undefined reference: java.util.function.Predicate
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_2/hazelcast/src/main/java/com/hazelcast/cluster/impl/TcpIpJoiner.java:485: Undefined reference: boolean java.util.Collection.removeIf(java.util.function.Predicate)
--------------------------

@TomaszGaweda
Copy link
Contributor

Great job 👍

Ufuk Yılmaz and others added 2 commits August 1, 2022 12:12
This change includes exposing member address retention duration
property in GroupProperty.
@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Aug 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ufukyilmaz
❌ Ufuk Yılmaz


Ufuk Yılmaz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the backport, Ufuk.

@kwart kwart merged commit f6d1baa into hazelcast:3.12.z Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants