New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.12.z] Remember previously joined member addresses in TcpIpJoiner #21860
[3.12.z] Remember previously joined member addresses in TcpIpJoiner #21860
Conversation
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.20:check (source-java6-check) on project hazelcast: Signature errors found. Verify them and ignore them with the proper annotation if needed. -> [Help 1] -------------------------- ---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_2/hazelcast/src/main/java/com/hazelcast/cluster/impl/TcpIpJoiner.java:485: Undefined reference: java.util.function.Predicate -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_2/hazelcast/src/main/java/com/hazelcast/cluster/impl/TcpIpJoiner.java:485: Undefined reference: boolean java.util.Collection.removeIf(java.util.function.Predicate) -------------------------- |
hazelcast/src/main/java/com/hazelcast/cluster/impl/TcpIpJoiner.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/MembershipManager.java
Show resolved
Hide resolved
hazelcast/src/test/java/com/hazelcast/cluster/TcpIpJoinTest.java
Outdated
Show resolved
Hide resolved
Great job 👍 |
This change includes exposing member address retention duration property in GroupProperty.
Ufuk Yılmaz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the backport, Ufuk.
This PR is the partial backport of #21552.
It only includes address remembering mechanism, not include the config update part.
Checklist:
Team:
,Type:
,Source:
,Module:
) and Milestone setAdd to Release Notes
orNot Release Notes content
set@Nonnull/@Nullable
annotations@since
tags in Javadoc