Make TcpServerConnection.equals more robust [HZ-1202] (5.1.z) #21641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwart
added
Team: Core
Backport
Type: Cleanup
Source: Internal
olukas
approved these changes
Jun 20, 2022
|
The job Click to expand the log file---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_2/extensions/kinesis/target/classes (Is a directory) -------------------------- -------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] ClientSemaphoreThreadedTest.concurrent_trySemaphoreWithTimeOutTest:67->concurrent_trySemaphoreTest:87 Timeout waiting for thread Thread-5 to terminate [ERROR] ClientScheduledExecutorServiceBasicTest>ScheduledExecutorServiceBasicTest.scheduleOnMember_whenAutoDisposable_thenGet:982->ScheduledExecutorServiceBasicTest.assertTaskHasBeenDestroyedEventually:997->HazelcastTestSupport.assertTrueEventually:1243->HazelcastTestSupport.assertTrueEventually:1226->ScheduledExecutorServiceBasicTest.lambda$assertTaskHasBeenDestroyedEventually$2:997->HazelcastTestSupport.assertThrows:1430 Expected com.hazelcast.scheduledexecutor.StaleTaskException to be thrown, but nothing was thrown. [ERROR] QueueDestroyTest.checkStatsMapEntryRemovedWhenQueueDestroyed:78 expected:<0> but was:<1> [ERROR] JobTimeoutTest.when_jobIsResumedAndExceedsTimeout_jobIsCancelled:91->JetTestSupport.assertJobStatusEventually:302->HazelcastTestSupport.assertTrueEventually:1243->HazelcastTestSupport.assertTrueEventually:1226->JetTestSupport.lambda$assertJobStatusEventually$2:303 jobId=0834-61d1-f800-0001 expected: but was: [ERROR] Errors: [ERROR] ClientTxnMapNearCacheTest.put_invalidates_server_side_near_cache:113 ? TransactionTimedOut [ERROR] ClientTxnMapNearCacheTest.remove_invalidates_server_side_near_cache:132 ? TransactionTimedOut [ERROR] ClientTxnMapNearCacheTest.replaceIfSame_invalidates_server_side_near_cache:189 ? TransactionTimedOut [ERROR] ClientTxnMapNearCacheTest.replace_invalidates_server_side_near_cache:170 ? TransactionTimedOut [ERROR] MetricsTest.test_sourceSinkTag:459->assertSourceSinkTags:469 ? IndexOutOfBounds [INFO] [ERROR] Tests run: 46807, Failures: 4, Errors: 5, Skipped: 239 [INFO] |
|
run-lab-run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #21631
The change improves the
TcpServerConnection.equalsmethod by adding more fields to compare.