Fix hanging cluster safe query from common pool #21208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all FJP#commonPool threads are busy querying isClusterSafe and partition assignments are not in sync (eg during initial partition arrangement), then there is no chance for an important callback to be executed after PartitionBackupReplicaAntiEntropyOperation is done, resulting in neither partition replica sync nor cluster-safe query being able to make any progress. The fix is to use the Hazelcast internal async executor (instead of the common pool) for the callback that processes replica antientropy operation result. (cherry picked from commit 434d731)
vbekiaris
added
Type: Defect
Team: Core
Backport
Source: Internal
ahmetmircik
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all FJP#commonPool threads are busy querying isClusterSafe
and partition assignments are not in sync (eg during initial
partition arrangement), then there is no chance for an important
callback to be executed after PartitionBackupReplicaAntiEntropyOperation
is done, resulting in neither partition replica sync nor cluster-safe
query being able to make any progress.
The fix is to use the Hazelcast internal async executor (instead of
the common pool) for the callback that processes replica antientropy
operation result.
(cherry picked from commit 434d731)
Backport of #21145 to 5.1.z