Don't allow empty memberlist on cluster id changes [API-1215] (#20818) #21178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast#20818) * Dont allow empty memberlist on cluster id changes When cluster id changed we were resetting member list with an empty memberlist. It turned out that there are implementations that assumes it will never be empty. Following test failure is an example of it. hazelcast#20264 Instead of clearing the memberlist on cluster id change, we are keeping the cluster id as part of the latest snapshot to be able to fire correct events. Note that clearing memberlist on cluster id change was introduced as a fix to hazelcast#18245 So it is important not to break related ClientHotRestartTest fixes hazelcast#20264 * Refactor ClusterService to make it unittestable Move getClient API out to reduce dependency to HazelcastInstanceImpl * Refactor: ClusterService to be able to unittest ClusterService does not depend on connection manager and client anymore. * Add unittest for ClientClusterServiceImpl Also revised the fix to cover blue/green case as well. ClientClusterService will not serve empty memberlist even when blue/green is happening. (cherry picked from commit 4d6fc11) Add method to ClientClusterService for enterprise tests (hazelcast#21169) (cherry picked from commit 1c769a2)
sancar
added
Type: Defect
Team: Client
Source: Internal
|
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] Failed to execute goal on project hazelcast-jet-cdc-debezium: Could not resolve dependencies for project com.hazelcast.jet:hazelcast-jet-cdc-debezium:jar:5.1.2-SNAPSHOT: Could not transfer artifact org.lz4:lz4-java:jar:1.8.0 from/to nexus-proxy (http://jenkins.hazelcast.com:8081/content/groups/public/): /home/jenkins/.m2/repository/org/lz4/lz4-java/1.8.0/lz4-java-1.8.0.jar.part (No such file or directory) -> [Help 1] -------------------------- |
|
run-lab-run |
|
run-ee-compile |
utku-caglayan
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cluster id changed we were resetting member list
with an empty memberlist. It turned out that there are implementations
that assumes it will never be empty.
Following test failure is an example of it.
#20264
Instead of clearing the memberlist on cluster id change, we
are keeping the cluster id as part of the latest snapshot
to be able to fire correct events.
Note that clearing memberlist on cluster id change was
introduced as a fix to #18245
So it is important not to break related ClientHotRestartTest
fixes #20264
Move getClient API out to reduce dependency to
HazelcastInstanceImpl
ClusterService does not depend on connection manager
and client anymore.
Also revised the fix to cover blue/green case as well.
ClientClusterService will not serve empty memberlist even when
blue/green is happening.
(cherry picked from commit 4d6fc11)
Add method to ClientClusterService for enterprise tests (#21169)
(cherry picked from commit 1c769a2)
backport of #20818 and #21169