[5.1.z] Fix race in SingleProtocolEncoder [HZ-1008] #20994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleProtocolEncoder#signalProtocolVerified was called from the decoder side, which runs on the input IO-thread, while SingleProtocolEncoder#onWrite is called from the output IO-thread. Since the shared state variables that these methods access are not volatile, there was a data race. Also, `isDecoderReceivedProtocol` is the first checked state variable in onWrite method, so we have to update it last on the signal methods -> changed the order of updates to satisfy this. (cherry picked from commit 9e1ec99)
ufukyilmaz
added
Type: Defect
Team: Core
Source: Internal
vbekiaris
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingleProtocolEncoder#signalProtocolVerified was called from the
decoder side, which runs on the input IO-thread, while
SingleProtocolEncoder#onWrite is called from the output IO-thread.
Since the shared state variables that these methods access are not
volatile, there was a data race. Also,
isDecoderReceivedProtocolisthe first checked state variable in onWrite method, so we have to
update it last on the signal methods -> changed the order of updates to
satisfy this.
(cherry picked from commit 9e1ec99)
Backport: #20991
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset