Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hazelcast-all module #19106

Merged
merged 2 commits into from Jul 22, 2021
Merged

Remove hazelcast-all module #19106

merged 2 commits into from Jul 22, 2021

Conversation

frant-hartm
Copy link
Collaborator

@frant-hartm frant-hartm commented Jul 15, 2021 •
edited by kwart

The EE counterpart: hazelcast/hazelcast-enterprise#4128

@frant-hartm frant-hartm added Team: Core Type: Cleanup Source: Internal PR or issue was opened by an employee labels Jul 15, 2021
@frant-hartm frant-hartm added this to the 5.0 milestone Jul 15, 2021
kwart
kwart requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you prepare also the EE counterpart PR? The hazelcast-enterprise-all depends on the hazelcast-all.

pom.xml Outdated Show resolved Hide resolved
@frant-hartm
Copy link
Collaborator Author

This is the EE counterpart https://github.com/hazelcast/hazelcast-enterprise/pull/4128.

mmedenjak
mmedenjak approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@mmedenjak mmedenjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, only controversial change was the pom.xml which Josef already pointed out to.

@frant-hartm frant-hartm merged commit ae4f681 into hazelcast:master Jul 22, 2021
@frant-hartm frant-hartm deleted the remove-hazelcast-all branch July 22, 2021 07:17
kwart added a commit to kwart/hazelcast that referenced this pull request Jul 28, 2021
@kwart
backport PR hazelcast#19106 - don't use hazelcas-all in docker snapho…
a5d417d 
…st images, use basic hazelcast JARs
kwart added a commit to kwart/hazelcast that referenced this pull request Jul 28, 2021
@kwart
backport PR hazelcast#19106 - don't use hazelcas-all in docker snapho…
1fbe1bf 
…st images, use basic hazelcast JARs
kwart added a commit to kwart/hazelcast that referenced this pull request Jul 28, 2021
@kwart
backport PR hazelcast#19106 - don't use hazelcas-all in docker snapho…
2bc8137 
…st images, use basic hazelcast JARs
kwart added a commit to kwart/hazelcast that referenced this pull request Jul 28, 2021
@kwart
backport PR hazelcast#19106 - don't use hazelcas-all in docker snapho…
65eea62 
…st images, use basic hazelcast JARs
This was referenced Jul 28, 2021
Merged
Merged
Merged
Merged
kwart added a commit that referenced this pull request Jul 28, 2021
@kwart
backport PR #19106 - don't use hazelcas-all in docker snaphost images…
82ea1b3 
…, use basic hazelcast JARs
kwart added a commit that referenced this pull request Jul 28, 2021
@kwart
backport PR #19106 - don't use hazelcas-all in docker snaphost images…
d2b0208 
…, use basic hazelcast JARs
kwart added a commit that referenced this pull request Jul 28, 2021
@kwart
backport PR #19106 - don't use hazelcas-all in docker snaphost images…
071fca5 
…, use basic hazelcast JARs
kwart added a commit that referenced this pull request Jul 28, 2021
@kwart
backport PR #19106 - don't use hazelcas-all in docker snaphost images…
ba924d4 
…, use basic hazelcast JARs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwart kwart kwart approved these changes

@mmedenjak mmedenjak mmedenjak approved these changes

Assignees
No one assigned
Labels
Source: Internal PR or issue was opened by an employee Team: Core Type: Cleanup
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frant-hartm @kwart @mmedenjak