Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2 Backport] - Partition Group API now takes members as method argument #18904

Closed
wants to merge 1 commit into from
Closed

[4.2 Backport] - Partition Group API now takes members as method argument #18904

wants to merge 1 commit into from

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Jun 14, 2021 •
edited

Back-port of #18794 to 4.2.x

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Add Add to Release Notes label if changes should be mentioned in release notes or Not Release Notes content if changes are not relevant for release notes
  • Request reviewers if possible
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc
  • Send backports/forwardports if fix needs to be applied to past/future releases

@lprimak lprimak requested a review from a team as a code owner June 14, 2021 16:36
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Jun 14, 2021
@lprimak lprimak changed the base branch from master to 4.2.z June 14, 2021 16:37
@nfrankel
Copy link
Contributor

run-lab-run

@mmedenjak mmedenjak added this to the 4.2.1 milestone Jun 14, 2021
@lprimak lprimak force-pushed the MEMBER_SPI_4.2.z branch 2 times, most recently from 38a614f to 8caa6e6 Compare June 20, 2021 01:45
ahmetmircik
ahmetmircik approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@ahmetmircik ahmetmircik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lprimak
added new API method getPartitionGroupStrategy(Collection<? extends M…
00c69c7 
…ember> allMembers)

to allow the implementor to have access to cluster members
@lprimak
Copy link
Contributor Author

lprimak commented Jun 21, 2021

squashed the commits

@vbekiaris
Copy link
Collaborator

run-lab-run

@Holmistr
Copy link
Contributor

After discussion with @lprimak on Slack, we'll not include this in the patch release but only in 5.0.

@Holmistr Holmistr closed this Jun 25, 2021
@lprimak lprimak deleted the MEMBER_SPI_4.2.z branch June 25, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetmircik ahmetmircik ahmetmircik approved these changes

Assignees
No one assigned
Labels
Backport Module: Discovery SPI [OLD]Team: Integration Source: Community PR or issue was opened by a community user Team: Core Type: Enhancement
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lprimak @devOpsHazelcast @nfrankel @vbekiaris @Holmistr @ahmetmircik @mmedenjak @hz-devops-test