[BACKPORT] Fixed a data loss issue on lite member promotion (#17644) #17758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notify cluster members on lite member promotion to update memberGroupSize. Otherwise, a data member might be not aware of other promoted data members, and it may cause backup operations not being issued to other data members. Closes hazelcast#17621
petrpleshachkov
added
Type: Defect
Team: Core
Backport
Priority: Medium
Source: Internal
petrpleshachkov
changed the title
vbekiaris
approved these changes
Oct 27, 2020
| thirdHazelcastInstance.getCluster().promoteLocalLiteMember(); | ||
|
|
||
| // check if cluster is in a good shape | ||
| assertTrueEventually(new AssertTask() { |
There was a problem hiding this comment.
nit: could use waitClusterForSafeState here and assertEqualsEventually in subsequent assertTrueEventually usages below.
mmedenjak
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify cluster members on lite member promotion to update
memberGroupSize. Otherwise, a data member might be not aware of other
promoted data members, and it may cause backup operations
not being issued to other data members.
Closes #17621
Backport of: #17644