New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add caller stacktrace to rethrown RuntimeException (#17249)" #17523
Conversation
This reverts commit 3fb90fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with correctness of the revert, but we need to reopen #17202 if we merge this one. And once we reopen it, we have a high prio defect with 4.0.3 milestone. So, we probably need to find a way to fix it.
@puzpuzpuz I'm actually doubting the priority of that issue. It says:
To me it sounds like a usability enhancement, when debugging or analysing issues. And it's not a regression introduced in 4.0.3, seems like it's the consequence of a 4.0 PR (#15441). |
@mmedenjak OK, then the issue could be addressed in the next patch release. |
Thank you for the reviews, everyone! 🙇 |
This reverts commit 318b336. Reasoning is that it introduces
significant changes in the invocation handling and causes some tests to
start failing (see #6383).
An alternate or augmented solution must be considered.
EDIT: had to revert #17438 as well since it relied on a method in
ExceptionUtil
which was introduced by the above commit.