ClientReauthOperation should be retryable #13790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sancar
force-pushed
the
fix/trySetLastAuthenticationCorrelationId/maint3.x
branch
from
6fafe52
to
6a02f4c
Compare
ClientReauthOperation is used with `invokeOnStableClusterSerial` This requires for the operation should be safely retyable. Before ClientReauthOperation was always throwing exception because it was expecting to the new correlation id is always greater. We are allowing it to be equal or greater than to last set correlation id to make the operation safely retryable. fixes https://github.com/hazelcast/hazelcast/issues/13758 (cherry picked from commit 6e2e1dc)
sancar
force-pushed
the
fix/trySetLastAuthenticationCorrelationId/maint3.x
branch
from
6a02f4c
to
a133fc9
Compare
sancar
deleted the
fix/trySetLastAuthenticationCorrelationId/maint3.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientReauthOperation is used with
invokeOnStableClusterSerialThis requires for the operation to be safely retyable.
Before ClientReauthOperation was always throwing exception because
it was expecting to the new correlation id is always greater.
We are allowing it to be equal or greater than to last set
correlation id to make the operation safely retryable.
fixes https://github.com/hazelcast/hazelcast/issues/13758
(cherry picked from commit 6e2e1dc)