SerializationException propagated to client when response unserializable #13777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sancar
force-pushed
the
fix/unserializableResponseToClient/maint3.x
branch
2 times, most recently
from
8db66a5
to
6974725
Compare
When an unserializableResponse is trying to be send to client as response from executor service tasks, the exception was logged on the server side, and there was no response returned back to the client. This pr, removes the logging in such case and sends related expcetion, (HazelcastSerializationException) to the client. Similar behaviour is also tested for the core side and verified it already works as expected. fixes hazelcast#13639 (cherry picked from commit 8fbdc58)
sancar
force-pushed
the
fix/unserializableResponseToClient/maint3.x
branch
from
6974725
to
53cebdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an unserializableResponse is trying to be send to client as response
from executor service tasks, the exception was logged on the server side,
and there was no response returned back to the client.
This pr, removes the logging in such case and sends related expcetion,
(HazelcastSerializationException) to the client.
Similar behaviour is also tested for the core side and verified it
already works as expected.
fixes #13639
(cherry picked from commit 8fbdc58)