[BACKPORT]Added storage destroy to release HD resources. #13659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
changed the title
ahmetmircik
added
Team: Core
Type: Test-Failure
Type: Defect
and removed
Type: Test-Failure
labels
ahmetmircik
force-pushed
the
fix/3.10.5/hdLeakTest
branch
from
88abbb7
to
06eba0b
Compare
taburet
approved these changes
Aug 30, 2018
ahmetmircik
force-pushed
the
fix/3.10.5/hdLeakTest
branch
from
06eba0b
to
a1a7c16
Compare
To release key+value pairs storage#clear should be called besides storage#destroy because it only releases internal resources of backing data structure not key+value pairs
ahmetmircik
force-pushed
the
fix/3.10.5/hdLeakTest
branch
from
a1a7c16
to
4c1e305
Compare
mmedenjak
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To release key+value pairs storage#clear should be called,
storage#destroy only releases internal resources of backing
data structure
closes https://github.com/hazelcast/hazelcast-enterprise/issues/859