Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock operations get timeout exception when member dies #13551

Closed
sancar opened this issue Aug 9, 2018 · 0 comments · Fixed by #13552
Closed

Lock operations get timeout exception when member dies #13551

sancar opened this issue Aug 9, 2018 · 0 comments · Fixed by #13552
Assignees
@sancar
Labels
Source: Internal PR or issue was opened by an employee Team: Client Type: Defect
Milestone
3.10.5

Comments

@sancar
Copy link
Contributor

sancar commented Aug 9, 2018

When a client waiting for a lock to be released more than invocation timeout seconds, and the member dies, clients get operation timeout exception rather than it is redirected to another member.
@sancar sancar added this to the 3.10.5 milestone Aug 9, 2018
@sancar sancar self-assigned this Aug 9, 2018
sancar pushed a commit to sancar/hazelcast that referenced this issue Aug 9, 2018
Fix lock timeout behaviour when key owner is gone
79fac3c 
When a client waiting on lock to get it, if the member that it
is waiting on shuts down/terminated , client retries it on new
owner of the lock.

If a client waits for longer than client.invocation.timeout.seconds,
when exception came from server, it is wrapped inside
OperationTimeoutException and thrown to user.
This pr changes this behaviour so that waiting lock operations
(map.lock/trylock lock.lock/trylock condition.await) operations will
not throw OperationTimeoutException but retry the operation.

fixes hazelcast#13551
@sancar sancar mentioned this issue Aug 9, 2018
Merged
sancar pushed a commit to sancar/hazelcast that referenced this issue Aug 9, 2018
Fix lock timeout behaviour when key owner is gone
53933cf 
When a client waiting on lock to get it, if the member that it
is waiting on shuts down/terminated , client retries it on new
owner of the lock.

If a client waits for longer than client.invocation.timeout.seconds,
when exception came from server, it is wrapped inside
OperationTimeoutException and thrown to user.
This pr changes this behaviour so that waiting lock operations
(map.lock/trylock lock.lock/trylock condition.await) operations will
not throw OperationTimeoutException but retry the operation.

fixes hazelcast#13551

(cherry picked from commit 79fac3c)
@sancar sancar mentioned this issue Aug 9, 2018
Merged
This was referenced Aug 28, 2018
Open
Closed
Closed
Closed
Open
@frapana frapana mentioned this issue Jul 18, 2019
Closed
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sancar sancar

Labels
Source: Internal PR or issue was opened by an employee Team: Client Type: Defect
Projects
None yet
Milestone
3.10.5
Development

Successfully merging a pull request may close this issue.

Fix lock timeout behaviour when key owner is gone sancar/hazelcast
2 participants
@sancar @mmedenjak