Split-Brain Merge Policies for Additional Data Structures

[Donnerbart]

Known issues:

• OOME on IQueue split-brain healing (IQueue Split heal OOME #11937) (was waiting for a wrong amount of semaphore permits)
• We should not allow to add dynamic configs for concurrent data structures during RU (We should not allow to add dynamic configs for concurrent data structures during RU #12000) (added cluster version check)
• MultiMap merge operation isn't a BlockingOperation and doesn't acquire key locks (see MultiMapBackupAwareOperation) (locked keys are ignored during mering)
• MultiMapConfig.equals() test fails and is ignored (fixed)
• Consider split brain merging keyless data structures (Consider split brain merging keyless data structures #12194)
• Data loss on IMap legacy split-brain healing (IMap data loss, tcp split brain heal #11999) (was no split-brain related issue)
• Data loss on IMap.put() after split-brain healing (data loss map put after split brain  #12037)
• Data loss on ISet during split-brain healing (split brain heal ISet data loss. #12234)
• Fail-fast when custom merge policy is not appropriate (Fail-fast when custom merge policy is not appropriate #12284)
• Split-brain merge policy design issues (Split-brain merge policy design issues #12721)
• Split-brain merge policy config validation is wrong (Split-brain merge policy config validation is wrong #12722)
• Split-brain merging entries are wasting memory and network capacity (Split-brain merging entries are wasting memory and network capacity #12725)
• Split-brain merging of collection like data structures is lossy (Split-brain merging of collection like data structures is lossy #12803)
• Return type of split-brain merge policy may be unclear and unflexible (Return type of split-brain merge policy may be unclear and unflexible #12804)
• Split-brain healing doesn't set the statistics from merged values in all data structures (Split-brain healing doesn't set the statistics from merged values in all data structures #12805)
• Update reference manual and javadoc for latest updates to split brain merging (Update reference manual and javadoc for latest updates to split brain merging hazelcast-reference-manual#515)

Test failures:

• AtomicLongSplitBrainTest fails spuriously (0 instead of 43)
  (was testing backups on the wrong instance)
• AtomicReferenceSplitBrainTest fails spuriously (null instead of 43)
  (was testing backups on the wrong instance, also a leftover assertion which always failed)
• SetSplitBrainTest and ListSplitBrainTest lose backups (Backup mismatch in SetSplitBrainTest and ListSplitBrainTest #11930) (internal item ID was not correctly set on backup promotion)
• ReplicatedMapSplitBrainTest fails spuriously with existing split-brain implementation (ReplicatedMapSplitBrainTest.testSplitBrain #11758) (ReplicatedMap statistics are not replicated, so we have to use keys on the same node like the proxy we are interacting with)
• ScheduledExecutorSplitBrainTest (ScheduledExecutorSplitBrainTest #12255)
• CacheSplitBrainTest (CacheSplitBrainTest Failures #9335)
• MapSplitBrainTest (MapSplitBrainTest #12263)

Pull requests:

• Improved JavaDoc and small cleanup of MergePolicy related classes (Improved JavaDoc and small cleanup of MergePolicy related classes #11654)
• Cleanup of SplitBrainTestSupport and SplitBrainHandlerService classes (Cleanup of SplitBrainTestSupport and SplitBrainHandlerService classes #11672)
• Added ReplicatedMapSplitBrainTest (Added ReplicatedMapSplitBrainTest #11719)
• Fixed setting of wrong expiration and last stored time in EntryViews (Fixed setting of wrong expiration and last stored time in EntryViews #11718)
• [BACKPORT] Fixed setting of wrong expiration and last stored time in EntryViews ([BACKPORT] Fixed setting of wrong expiration and last stored time in EntryViews #11740)
• Changed default brains in SplitBrainTestSupport (Changed default brains in SplitBrainTestSupport #11728)
• Cleanup of Spring related classes (Cleanup of Spring related classes #11916)
• Cleanup of Spring XML files (Cleanup of Spring XML files #11917)
• Cleanup of Hazelcast XML files (Cleanup of Hazelcast XML files #11927)
• Fixed lost CollectionItems on backup promotion in ISet and IList (Fixed lost CollectionItems on backup promotion in ISet and IList #12061)
• [BACKPORT] Fixed lost CollectionItems on backup promotion in ISet and IList ([BACKPORT] Fixed lost CollectionItems on backup promotion in ISet and IList #12064)
• Added configuration for IAtomicLong and IAtomicReference (Added configuration for IAtomicLong and IAtomicReference #11910)
• Added backup tests for IList, IQueue and ISet (Added backup tests for IList, IQueue and ISet #11978)
• Added backup tests for MultiMap (Added backup tests for MultiMap #11980)
• Added cluster version check for dynamic atomic configurations (Added cluster version check for dynamic atomic configurations #12006)
• Added MapSplitBrainStressTest (Added MapSplitBrainStressTest #12030)
• Added common SplitBrainMergePolicy classes for additional data structures (Added common SplitBrainMergePolicy classes for additional data structures #11788)
  • Added MergePolicyConfig to AbstractBasicConfig classes (Added MergePolicyConfig to AbstractBasicConfig classes #11963)
    • Implemented split-brain healing for IAtomicLong (Implemented split-brain healing for IAtomicLong #11899)
    • Implemented split-brain healing for IAtomicReference (Implemented split-brain healing for IAtomicReference #11912)
  • Added unified split-brain healing to IMap (OS) (Added unified split-brain healing to IMap #11835)
  • Added unified split-brain healing to IMap (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1890)
  • Added unified split-brain healing to ICache (OS) (Added unified split-brain healing to ICache #12189)
  • Added unified split-brain healing to ICache (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1891)
  • Added unified split-brain healing to ReplicatedMap (Added unified split-brain healing to ReplicatedMap #12196)
  • Implemented split-brain healing for MultiMap (Implemented split-brain healing for MultiMap #11964)
  • Implemented split-brain healing for Ringbuffer (Implemented split-brain healing for Ringbuffer #11752)
  • Implemented split-brain healing for IQueue (Implemented split-brain healing for IQueue #11749)
  • Implemented split-brain healing for ISet and IList (Implemented split-brain healing for ISet and IList #11677)
  • Implement split-brain healing for CardinalityEstimator (HLL) (Implement split-brain healing for CardinalityEstimator (HLL) #12139)
  • Implement split-brain healing for IScheduledExecutorService (Implement split-brain healing for IScheduledExecutorService #12046)
  • Unified split-brain healing for WAN replication (OS) (Unified split-brain healing for WAN replication #12241)
  • Unified split-brain healing for WAN replication (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1899)
• Added QuorumOperationsTest and fixed operations (Added QuorumOperationsTest and fixed operations #12212)
• Fixed split-brain healing of CardinalityEstimator (Fixed split-brain healing of CardinalityEstimator #12253)
• Added missing fail() branch to split-brain tests (Added missing fail() branch to split-brain tests #12254)
• Added missing // RU_COMPAT_3_9 comments (Added missing // RU_COMPAT_3_9 comments #12260)
• Small cleanup of RingbufferConfig (Small cleanup of RingbufferConfig #12261)
• Added SplitBrainUpgradeCaseMergePolicyTest (https://github.com/hazelcast/hazelcast-enterprise/pull/1901)
• Fixed the timeout calculation in split-brain healing services (Fixed the timeout calculation in split-brain healing services #12268)
• Improved logging of split-brain healing failures (Improved logging of split-brain healing failures #12269)
• Fixed deserialization of merge operations (Fixed deserialization of merge operations #12305)
• Fix failing IScheduledExecutor test on split-brain healing (Fix failing IScheduledExecutor GetAllScheduledFutures #12304)
• SplitBrainMergePolicy design improvements (SplitBrainMergePolicy design improvements #12321)
• Removed interface SplitBrainAwareDataContainer (Removed interface SplitBrainAwareDataContainer #12322)
• Adds merge policy config for dynamic configs (Adds merge policy config for dynamic configs hazelcast-client-protocol#115)
• Set merge policy config when adding dynamic config from client side (Set merge policy config when adding dynamic config from client side #12299)
• Added merge policies to ConfigValidator (Added merge policies to ConfigValidator #12347)
• Improved split-brain SPI design (OS) (Improved split-brain SPI design #12301)
• Improved split-brain SPI design (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1921)
• Improved backup testing utils (Improved backup testing utils #12364)
• Map&Cache SplitBrainHandlerService unifications (OS) (Map&Cache SplitBrainHandlerService unifications #12370)
• Map&Cache SplitBrainHandlerService unifications (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1926)
• Improved split-brain SPI design (OS) (Improved split-brain SPI design #12441)
• Improved split-brain SPI design (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1947)
• Fixed visibility issue in split-brain recovery (Fixed visibility issue in split-brain recovery #12466)
• Fixed ScheduledExecutorContainer and enhanced split-brain test (Fixed ScheduledExecutorContainer and enhanced split-brain test #12497)
• Fixed ReplicatedMap with lite members and lite member promotion (Fixed ReplicatedMap with lite members and lite member promotion #12538)
  • Unified ReplicatedMapSplitBrainHandlerService with IMap and ICache (Unified ReplicatedMapSplitBrainHandlerService with IMap and ICache #12503)
• Renamed split-brain value type classes (OS) (Renamed split-brain value type classes #12571)
• Renamed split-brain value type classes (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1972)
• Moved SplitBrainMergePolicy to package com.hazelcast.spi.impl.merge (OS) (Moved SplitBrainMergePolicy to package com.hazelcast.spi.merge #12596)
• Moved SplitBrainMergePolicy to package com.hazelcast.spi.impl.merge (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1985)
• Fixed merge policy check in ConfigValidator (OS) (Fixed merge policy check in ConfigValidator #12627)
• Fixed merge policy check in ConfigValidator (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/1992)
• Cleanup of ConfigValidator tests (Cleanup of ConfigValidator tests #12658)
• Revert conversion to Lite member during Split-Brain healing (OS) (Revert conversion to Lite member during Split-Brain healing #12691)
• Removed HD Split-Brain merge code (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/2021)
• Fixed split-brain merge policy design (OS) (Fixed split-brain merge policy design #12573)
• Fixed split-brain merge policy design (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/2002, https://github.com/hazelcast/hazelcast-enterprise/pull/2040)
• Use entire ringbuffers during split brain healing (Use entire ringbuffers during split brain healing #12792)
• Fixed merging of MultiMap values (Fixed merging of MultiMap values #12775)
• Fixed merging of ISet/IList ( Fixed merging of ISet/IList #12799)
• Fixed merging of IQueue (Fixed merging of IQueue #12802)
• Fixed merging of IAtomicLong/IAtomicReference (Fixed merging of IAtomicLong/IAtomicReference #12827)
• Fixed DiscardMergePolicy detection in AbstractSplitBrainHandlerService (Fixed DiscardMergePolicy detection in AbstractSplitBrainHandlerService #12842)
• Added additional merge policies to test user created values (Added additional merge policies to test user created values #12843)
• Fixed merging of IMap and ICache (OS) ([DONT MERGE] Fixed merging of IMap and ICache #12847)
• Fixed merging of IMap and ICache (EE) (https://github.com/hazelcast/hazelcast-enterprise/pull/2055)
• Added additional merge policies to ReplicatedMapSplitBrainTest (Added additional merge policies to ReplicatedMapSplitBrainTest #12859)
• Added @Beta annotation to split-brain SPI interfaces and classes (Added @Beta annotation to split-brain SPI interfaces and classes #12860)
• Fixed creation of null MergingValue on merging nodes (Fixed creation of null MergingValue on merging nodes #12875)
• Added configuration examples for new merge policies (Added configuration examples for new merge policies hazelcast-code-samples#233)
• Added configuration examples for new merge policies (Added configuration examples for new merge policies hazelcast-code-samples#234)
• Added configuration examples for new merge policies (Added configuration examples for new merge policies hazelcast-code-samples#235)

[mmedenjak]

101 tasks! Congrats! 🎉

[Donnerbart]

I don't know if this is an achievement to be proud of, but thanks 😸