Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout does not seem to work #189

Open
tadayosi opened this issue Nov 13, 2023 · 3 comments
Open

Logout does not seem to work #189

tadayosi opened this issue Nov 13, 2023 · 3 comments

Comments

@tadayosi
Copy link
Member

Logout should take users to the OpenShift provider specific login page for prompting authentication.

Screencast.from.2023-11-13.14-41-54.webm
@phantomjinx
Copy link
Member

The logout is working correctly in that when button is clicked, the token is removed and in its absence, the app redirects to the login provider page. However, on an IBM cluster the login provider page logs straight back in and hawtio extracts it and logs back in again.

@tadayosi
Copy link
Member Author

tadayosi commented Dec 7, 2023

@phantomjinx I wonder how it worked with hawtio-online 1.x. If it worked well and logged us out from IBM cluster then we could do something similar for the new hawtio-online too.

@tadayosi
Copy link
Member Author

tadayosi commented Dec 7, 2023

The following code is dropped from the new hawtio-online. Isn't it because of that?

https://github.com/hawtio/hawtio-oauth/blob/303d9fe06f48abee7a16c6a6459a9296458de0e3/plugins/osOAuth/osOAuth.helpers.ts#L27-L35

    authenticatedHttpRequest({
      type: 'DELETE',
      url: uri.toString(),
    }, userDetails).always(() => {
      clearTokenStorage();
      doLogin(OSOAuthConfig, {
        uri: currentURI.toString(),
      });
    });

Note openshift/origin#7011 is closed so it doens't seem to be an issue anymore, is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants