Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation doesn't work properly in the plugins involves Tree #903

Open
mmelko opened this issue Apr 24, 2024 · 5 comments
Open

Navigation doesn't work properly in the plugins involves Tree #903

mmelko opened this issue Apr 24, 2024 · 5 comments
Labels
kind/enhancement Enhancements that don't necessarily result in a new feature
Milestone

Comments

@mmelko
Copy link
Collaborator

mmelko commented Apr 24, 2024

This might be caused by resolution of the path, where selected mbeans aren't included into the path, so i.e source of the route1 is translated to [host]/hawtio/camel/source. So when we paste this link to the browser we are automatically redirected to the root of the camel plugin with the context table.

Similar behaviour when we selected different mbean of the same type. Instead of perceive the selected tab it's automatically redirected to the first tab.

@mmelko mmelko added the kind/bug Something isn't working label Apr 24, 2024
@tadayosi
Copy link
Member

@mmelko Look at how Hawtio v2 did for the persistent navigation. I remember it used query parameters such as ?nid= for keeping the current mbean location. That said, I don't think using query params is a good design in 2024. So the first thing we should do would be to design how we encode the path location into URL. Do you have any ideas?

@tadayosi
Copy link
Member

I wouldn't say it's a bug so let me change it to enhancement.

@tadayosi tadayosi added kind/enhancement Enhancements that don't necessarily result in a new feature and removed kind/bug Something isn't working labels Apr 26, 2024
@tadayosi tadayosi added this to the 2024Q2 milestone Apr 26, 2024
@mmelko
Copy link
Collaborator Author

mmelko commented Apr 26, 2024

Sure, I marked is a bug because the functionality is lacking compared to v2.

My idea from top of my head is to use path param and mbean names (i.e [host]/hawtio/camel/source/routes) That would require extending either current context or create new with something like searchNode and then obtain the objectName.

@tadayosi
Copy link
Member

@mmelko Hmm, then how do we encode the selected node into the path? Should we still use a query parameter for the node selection?

@mmelko
Copy link
Collaborator Author

mmelko commented Apr 26, 2024

so bad example .. routes would be the name of the mbean (not the object name). so for route1 the path would look like [host]/hawtio/camel/source/route1 That's how I'd like to see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancements that don't necessarily result in a new feature
Projects
Status: Backlog
Development

No branches or pull requests

2 participants