Skip to content
This repository has been archived by the owner on Feb 28, 2020. It is now read-only.

!secret no longer works in apps.yaml #39

Closed
nickneos opened this issue Apr 2, 2019 · 6 comments
Closed

!secret no longer works in apps.yaml #39

nickneos opened this issue Apr 2, 2019 · 6 comments

Comments

@nickneos
Copy link

nickneos commented Apr 2, 2019

Problem/Motivation

having !secret in apps.yaml no longer works

Expected behavior

!secret is parsed in apps.yaml as was the case prior to last release

Actual behavior

2019-04-02 22:19:17.599568 INFO API is disabled
2019-04-02 22:19:17.629602 INFO AppDaemon: HASS: Connected to Home Assistant 0.90.2
2019-04-02 22:19:18.014390 INFO AppDaemon: Got initial state from namespace default
2019-04-02 22:19:22.822573 INFO AppDaemon: Reading config
2019-04-02 22:19:23.217004 WARNING AppDaemon: Error loading configuration
2019-04-02 22:19:23.217780 WARNING AppDaemon: parser says
2019-04-02 22:19:23.218490 WARNING AppDaemon:   in "<unicode string>", line 79, column 15:
          gw_mac: !secret xiaomi_mac
                  ^
2019-04-02 22:19:23.218930 WARNING AppDaemon: could not determine a constructor for the tag '!secret'
2019-04-02 22:19:23.220558 WARNING AppDaemon: File '/config/appdaemon/apps/apps.yaml' invalid structure - ignoring

Steps to reproduce

have a !secret reference in apps.yaml

Proposed changes

@addons-assistant
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

@Luke15153
Copy link

Perhaps it is related to this issue?
AppDaemon/appdaemon#538 (comment)

@frenck
Copy link
Member

frenck commented Apr 2, 2019

This add-on does only install AppDaemon:

https://github.com/hassio-addons/addon-appdaemon3/blob/master/appdaemon/requirements.txt

Dependencies of AppDaemon are not locked in by the add-on, but are defined in:

https://github.com/home-assistant/appdaemon/blob/dev/setup.py#L18

Since AppDaemon does not lock in a version, the latest PyYaml gets installed, which is apparently broken.

Sorry, but there is nothing I can do. As soon as AppDaemon releases a working version (by doing proper version pinning), I'll release an update as soon as possible.

GitHub
AppDaemon3 - Community Hass.io Add-on for Home Assistant - hassio-addons/addon-appdaemon3
GitHub
📄 Python Apps for Home Automation. Contribute to home-assistant/appdaemon development by creating an account on GitHub.

@nickneos
Copy link
Author

nickneos commented Apr 3, 2019

no worries...thanks

@frenck
Copy link
Member

frenck commented Apr 3, 2019

v2.0.2 of the add-on has just been released, which upgrades AppDaemon to v3.0.3, which addresses the secrets issue.

@frenck frenck closed this as completed Apr 3, 2019
@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants